-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graph Analytics #1022
Graph Analytics #1022
Conversation
Add a tab for graph analytics in projects page. This tab will display details from gaph analytics delta plugin.
Codecov Report
@@ Coverage Diff @@
## 1.7.0-M3 #1022 +/- ##
===========================================
Coverage ? 65.15%
===========================================
Files ? 22
Lines ? 640
Branches ? 137
===========================================
Hits ? 417
Misses ? 223
Partials ? 0 Continue to review full report at Codecov.
|
layout: { | ||
// @ts-ignore | ||
name: 'avsdf', | ||
// name: 'fcose' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove commented out code
return { | ||
nodes, | ||
// edges, | ||
// are not constructed properly because of this: https://github.com/BlueBrain/nexus/issues/2871 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this still the case? are we not including edges?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. This is still the case. I have removed the edge construction logic from POC, as it does not work properly. We will tackle it in a different issue.
const nodes = response._nodes.map((node: any) => ({ | ||
data: { id: node['@id'], label: `${node._name}\n${node._count}` }, | ||
style: { | ||
width: `${getDiameter(node._count)} px`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't think height and width values will be valid values here with space between value and 'px', remove space
// change node's color here | ||
}); | ||
graph.current.on('tap', 'edge', (e: cytoscape.EventObject) => { | ||
console.log('clicked on an edge!', e.target.id()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove console.log
* Graph Analytics Add a tab for graph analytics in projects page. This tab will display details from graph analytics delta plugin.
Add a tab for graph analytics in projects page. This tab will display details from gaph analytics delta plugin.
Fixes # BlueBrain/nexus/issues/2557
Description
Add Graph analytics tab to fusion
How has this been tested?
Types of changes
Checklist: