Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph Analytics #1022

Merged
merged 7 commits into from
Jan 13, 2022
Merged

Graph Analytics #1022

merged 7 commits into from
Jan 13, 2022

Conversation

dhaneshnm
Copy link
Contributor

@dhaneshnm dhaneshnm commented Jan 12, 2022

Add a tab for graph analytics in projects page. This tab will display details from gaph analytics delta plugin.

Fixes # BlueBrain/nexus/issues/2557

Description

Add Graph analytics tab to fusion

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

Add a tab for graph analytics in projects page. This tab will display details from gaph analytics delta plugin.
@dhaneshnm
Copy link
Contributor Author

Screenshot 2022-01-12 at 09 22 51

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2022

Codecov Report

❗ No coverage uploaded for pull request base (1.7.0-M3@a04d7bf). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             1.7.0-M3    #1022   +/-   ##
===========================================
  Coverage            ?   65.15%           
===========================================
  Files               ?       22           
  Lines               ?      640           
  Branches            ?      137           
===========================================
  Hits                ?      417           
  Misses              ?      223           
  Partials            ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a04d7bf...5dd6cf3. Read the comment docs.

layout: {
// @ts-ignore
name: 'avsdf',
// name: 'fcose'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove commented out code

return {
nodes,
// edges,
// are not constructed properly because of this: https://github.com/BlueBrain/nexus/issues/2871
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still the case? are we not including edges?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This is still the case. I have removed the edge construction logic from POC, as it does not work properly. We will tackle it in a different issue.

const nodes = response._nodes.map((node: any) => ({
data: { id: node['@id'], label: `${node._name}\n${node._count}` },
style: {
width: `${getDiameter(node._count)} px`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think height and width values will be valid values here with space between value and 'px', remove space

// change node's color here
});
graph.current.on('tap', 'edge', (e: cytoscape.EventObject) => {
console.log('clicked on an edge!', e.target.id());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove console.log

@dhaneshnm dhaneshnm merged commit 3617e7b into 1.7.0-M3 Jan 13, 2022
@dhaneshnm dhaneshnm deleted the 2557-GraphAnalytics branch January 13, 2022 13:12
dhaneshnm pushed a commit that referenced this pull request Mar 11, 2022
* Graph Analytics

Add a tab for graph analytics in projects page. This tab will display details from graph analytics delta plugin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants