Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Conversation

@nicwells
Copy link
Contributor

Fixes BlueBrain/nexus#2082

Description

The links section in Project Admin list resources linked in the resource didn't work with versioned identifiers, i.e. when @id=someid?rev=2. Delta doesn't support this functionality fully and it is difficult to implement. Therefore this change introduces support for versioned identifiers directly in Fusion i.e. displays them correctly and navigates to a specific revision when specified.

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2022

Codecov Report

❗ No coverage uploaded for pull request base (1.7.0-M3@3617e7b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             1.7.0-M3    #1023   +/-   ##
===========================================
  Coverage            ?   65.15%           
===========================================
  Files               ?       22           
  Lines               ?      640           
  Branches            ?      137           
===========================================
  Hits                ?      417           
  Misses              ?      223           
  Partials            ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3617e7b...758a5bb. Read the comment docs.

@nicwells nicwells force-pushed the 2082-admin-plugin-link-support-navigation-versioned-identifiers branch from b162bd1 to 758a5bb Compare January 14, 2022 08:27
@dhaneshnm dhaneshnm merged commit 5d03a41 into 1.7.0-M3 Jan 17, 2022
@dhaneshnm dhaneshnm deleted the 2082-admin-plugin-link-support-navigation-versioned-identifiers branch January 17, 2022 11:16
dhaneshnm pushed a commit that referenced this pull request Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants