Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2999 scale large pdfs down to size and support zoom/pan #1026

Merged
merged 5 commits into from
Jan 21, 2022

Conversation

nicwells
Copy link
Contributor

Fixes BlueBrain/nexus#2999

Description

Take height and width of pdf into consideration for determining size to display pdf at.
Support zooming and panning of pdf

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (1.7.0-M4@5d03a41). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             1.7.0-M4    #1026   +/-   ##
===========================================
  Coverage            ?   65.15%           
===========================================
  Files               ?       22           
  Lines               ?      640           
  Branches            ?      137           
===========================================
  Hits                ?      417           
  Misses              ?      223           
  Partials            ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d03a41...386be1b. Read the comment docs.

@dhaneshnm dhaneshnm merged commit 04abb6a into 1.7.0-M4 Jan 21, 2022
@dhaneshnm dhaneshnm deleted the 2999-scale-large-pdfs-down-to-size branch January 21, 2022 12:17
dhaneshnm pushed a commit that referenced this pull request Mar 11, 2022
* useMemo to prevent reloading pdf file each time

* Size PDF on page nicely

* Add zoom and panning support and nicer size adjustment

* Style some more and add error message when fails

* Fix linting and document
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants