This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Copy notification for button dropdowns#1034
Merged
Merged
Conversation
* Pass text to copy as function param rather than Copy component prop. This allows us to support dropdown copy buttons that have more than one possible copy text value. * Update references to component to use new interface * Use copy component to add notification to our dropdown button when text is copied
dhaneshnm
approved these changes
Jan 25, 2022
Codecov Report
@@ Coverage Diff @@
## 1.7.0-M4 #1034 +/- ##
===========================================
Coverage ? 66.61%
===========================================
Files ? 22
Lines ? 668
Branches ? 150
===========================================
Hits ? 445
Misses ? 223
Partials ? 0 Continue to review full report at Codecov.
|
dhaneshnm
approved these changes
Jan 28, 2022
dhaneshnm
pushed a commit
that referenced
this pull request
Mar 11, 2022
* Pass text to copy as function param rather than Copy component prop. This allows us to support dropdown copy buttons that have more than one possible copy text value. * Update references to component to use new interface * Use copy component to add notification to our dropdown button when text is copied Co-authored-by: Dhanesh Neela Mana <dhanesh.neelamana@epfl.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes BlueBrain/nexus#3014
Description
How has this been tested?
Types of changes
Checklist: