Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy notification for button dropdowns #1034

Merged
merged 2 commits into from
Jan 28, 2022

Conversation

nicwells
Copy link
Contributor

Fixes BlueBrain/nexus#3014

Description

  • Pass text to copy as function param rather than Copy component prop. This allows us to support dropdown copy buttons that have more than one possible copy text value.
  • Update references to component to use new interface
  • Use copy component to add notification to our dropdown button when text is copied

Copy notification

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

* Pass text to copy as function param rather than Copy component prop. This allows us to support dropdown copy buttons that have more than one possible copy text value.
* Update references to component to use new interface
* Use copy component to add notification to our dropdown button when text is copied
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2022

Codecov Report

❗ No coverage uploaded for pull request base (1.7.0-M4@fcbe4ab). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             1.7.0-M4    #1034   +/-   ##
===========================================
  Coverage            ?   66.61%           
===========================================
  Files               ?       22           
  Lines               ?      668           
  Branches            ?      150           
===========================================
  Hits                ?      445           
  Misses              ?      223           
  Partials            ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcbe4ab...b2b94d2. Read the comment docs.

@dhaneshnm dhaneshnm merged commit 78e1455 into 1.7.0-M4 Jan 28, 2022
@dhaneshnm dhaneshnm deleted the 3014-copy-token-not-showing-notification branch January 28, 2022 14:38
dhaneshnm pushed a commit that referenced this pull request Mar 11, 2022
* Pass text to copy as function param rather than Copy component prop. This allows us to support dropdown copy buttons that have more than one possible copy text value.
* Update references to component to use new interface
* Use copy component to add notification to our dropdown button when text is copied

Co-authored-by: Dhanesh Neela Mana <dhanesh.neelamana@epfl.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants