Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3113 search reset bug fix #1048

Merged
merged 4 commits into from
Feb 16, 2022
Merged

3113 search reset bug fix #1048

merged 4 commits into from
Feb 16, 2022

Conversation

nicwells
Copy link
Contributor

Fixes BlueBrain/nexus#3113

Description

  • Fixes search reset bug - will now reload the currently selected search config
  • Update theme-color to match our updated styles - used by Safari to set browser tab color
  • Fix styling of search table options - remove left space and fill same width as table
  • Fix auto height calculations to correctly calculate number of rows to fit on page
  • Remove unused logic to calculate number of columns to fit on page which was also causing issues with reset

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@dhaneshnm dhaneshnm merged commit 57100b6 into 1.7.0-M4 Feb 16, 2022
@dhaneshnm dhaneshnm deleted the 3113-search-reset-bug-fix branch February 16, 2022 08:55
smitfire added a commit that referenced this pull request Feb 16, 2022
…in/nexus-web into 3106-numeric-missing-bug

* '3106-numeric-missing-bug' of https://github.com/BlueBrain/nexus-web:
  3113 search reset bug fix (#1048)
  Remove biderictional arrows (#1047)
dhaneshnm pushed a commit that referenced this pull request Mar 11, 2022
* Fix reset to reset to currently selected search config

* Style improvements

* Update theme-color to match our styles

This will change the browser color where it is supported, e.g. Safari

* Fix table height auto adjust
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants