This repository was archived by the owner on Feb 26, 2025. It is now read-only.
3106 numeric missing bug - #1049
Merged
Merged
Conversation
Contributor
|
A '0' is being rendered currently when the numerical column options is first shown, see below
|
dhaneshnm
reviewed
Feb 16, 2022
| .aggregation('missing', filterKeyWord, '(missing)') | ||
| .build(); | ||
| nexusClient.Search.query(missingQuery).then(response => { | ||
| console.log('response'); |
Contributor
There was a problem hiding this comment.
let us remove the console logs
Codecov Report
@@ Coverage Diff @@
## 1.7.0-M4 #1049 +/- ##
===========================================
Coverage ? 66.61%
===========================================
Files ? 22
Lines ? 668
Branches ? 144
===========================================
Hits ? 445
Misses ? 223
Partials ? 0 Continue to review full report at Codecov.
|
dhaneshnm
self-requested a review
February 16, 2022 09:33
…in/nexus-web into 3106-numeric-missing-bug * '3106-numeric-missing-bug' of https://github.com/BlueBrain/nexus-web: 3113 search reset bug fix (#1048) Remove biderictional arrows (#1047)
nicwells
approved these changes
Feb 17, 2022
dhaneshnm
approved these changes
Feb 17, 2022
4 tasks
dhaneshnm
pushed a commit
that referenced
this pull request
Mar 11, 2022
* fix for missing counts and stats for numeric filters * prettier formatting Co-authored-by: Dhanesh Neela Mana <dhanesh.neelamana@epfl.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes BlueBrain/nexus#3106
Description
Missing count reflects the subsequent changes to numeric column data. Previously did not
How has this been tested?
Types of changes
Checklist: