Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load from ENV the name of service account realm to be hidden for Login #1050

Merged
merged 2 commits into from
Feb 16, 2022

Conversation

bogdanromanx
Copy link
Contributor

Description

Previously the service account realm name that was hidden for Login was hardcoded. The change allows the realm name to be picked up from environment variables.

The env variable is: SERVICE_ACCOUNTS_REALM

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

Previously the service account realm name was hardcoded. The change
allows the realm to be picked up from environment variables.

The env variable is: SERVICE_ACCOUNTS_REALM
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (1.7.0-M4@57100b6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             1.7.0-M4    #1050   +/-   ##
===========================================
  Coverage            ?   66.61%           
===========================================
  Files               ?       22           
  Lines               ?      668           
  Branches            ?      144           
===========================================
  Hits                ?      445           
  Misses              ?      223           
  Partials            ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57100b6...0ddd097. Read the comment docs.

Copy link
Contributor

@nicwells nicwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - welcome to the front-end 😉

@bogdanromanx bogdanromanx merged commit dd26405 into BlueBrain:1.7.0-M4 Feb 16, 2022
@bogdanromanx bogdanromanx deleted the hide-realm branch February 16, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants