Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case where there are multiple label values #1052

Merged
merged 3 commits into from
Feb 21, 2022

Conversation

nicwells
Copy link
Contributor

Fixes BlueBrain/nexus#3119

Description

Previously it was assumed there was a single label however there could be several. We now handle the case that there is more than one label.

Screenshot 2022-02-18 at 14 07 47

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2022

Codecov Report

❗ No coverage uploaded for pull request base (1.7.0-M4@295335f). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 1f97a79 differs from pull request most recent head 5ab4839. Consider uploading reports for the commit 5ab4839 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##             1.7.0-M4    #1052   +/-   ##
===========================================
  Coverage            ?   66.61%           
===========================================
  Files               ?       22           
  Lines               ?      668           
  Branches            ?      144           
===========================================
  Hits                ?      445           
  Misses              ?      223           
  Partials            ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 295335f...5ab4839. Read the comment docs.

@dhaneshnm dhaneshnm merged commit 05604ab into 1.7.0-M4 Feb 21, 2022
@dhaneshnm dhaneshnm deleted the 3119-global-search-multi-label-fields branch February 21, 2022 09:39
dhaneshnm pushed a commit that referenced this pull request Mar 11, 2022
Co-authored-by: Dhanesh Neela Mana <dhanesh.neelamana@epfl.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants