Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where deselecting filter value does not remove it #1054

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

nicwells
Copy link
Contributor

Fixes BlueBrain/nexus#3120

Description

Fix bug where deselecting filter value does not remove it

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@nicwells nicwells requested review from dhaneshnm and smitfire and removed request for dhaneshnm February 18, 2022 17:03
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (1.7.0-M4@20f30db). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             1.7.0-M4    #1054   +/-   ##
===========================================
  Coverage            ?   66.61%           
===========================================
  Files               ?       22           
  Lines               ?      668           
  Branches            ?      144           
===========================================
  Hits                ?      445           
  Misses              ?      223           
  Partials            ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20f30db...72152ab. Read the comment docs.

@dhaneshnm dhaneshnm merged commit 295335f into 1.7.0-M4 Feb 21, 2022
@dhaneshnm dhaneshnm deleted the 3120-global-search-deselect-filter branch February 21, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants