Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor edit table #1069

Merged
merged 5 commits into from Mar 23, 2022
Merged

Refactor edit table #1069

merged 5 commits into from Mar 23, 2022

Conversation

dhaneshnm
Copy link
Contributor

@dhaneshnm dhaneshnm commented Mar 22, 2022

  • persist the query in the query editor.
  • Refactor to improve readability and performance.

Description

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

- persist the query in the query editor.
- Refactor to improve redability and performance.
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2022

Codecov Report

❗ No coverage uploaded for pull request base (1.7.1@e9ecb18). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head bcc50a2 differs from pull request most recent head 1859041. Consider uploading reports for the commit 1859041 to get more accurate results

@@           Coverage Diff            @@
##             1.7.1    #1069   +/-   ##
========================================
  Coverage         ?   66.61%           
========================================
  Files            ?       22           
  Lines            ?      668           
  Branches         ?      144           
========================================
  Hits             ?      445           
  Misses           ?      223           
  Partials         ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9ecb18...1859041. Read the comment docs.

@dhaneshnm dhaneshnm merged commit 767550f into 1.7.1 Mar 23, 2022
@dhaneshnm dhaneshnm deleted the fix-table-bug branch March 23, 2022 08:17
dhaneshnm pushed a commit that referenced this pull request May 20, 2022
* Refactor edit table

- persist the query in the query editor.
- Refactor to improve readability and performance.
- Update Code mirror version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants