Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct url with destination #1073

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Correct url with destination #1073

merged 1 commit into from
Apr 7, 2022

Conversation

nicwells
Copy link
Contributor

@nicwells nicwells commented Apr 1, 2022

Fixes BlueBrain/nexus#3169

Description

Fixes issue where when user clicks login button they are briefly redirected (client-side) to the wrong path resulting in a 404 before being redirected (properly) to the login provider.

How has this been tested?

Tested locally with different base paths.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (1.7.1@5d46f91). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             1.7.1    #1073   +/-   ##
========================================
  Coverage         ?   66.61%           
========================================
  Files            ?       22           
  Lines            ?      668           
  Branches         ?      144           
========================================
  Hits             ?      445           
  Misses           ?      223           
  Partials         ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d46f91...72f6e63. Read the comment docs.

@nicwells nicwells merged commit 7fdd259 into 1.7.1 Apr 7, 2022
@nicwells nicwells deleted the 3169-login-404-briefly branch April 7, 2022 09:01
dhaneshnm pushed a commit that referenced this pull request May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants