Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

3184 honour filterable flag#1080

Merged
dhaneshnm merged 2 commits into1.7.1from
3184-honour-filterable-flag
Apr 26, 2022
Merged

3184 honour filterable flag#1080
dhaneshnm merged 2 commits into1.7.1from
3184-honour-filterable-flag

Conversation

@nicwells
Copy link
Contributor

Fixes BlueBrain/nexus#3184, BlueBrain/nexus#3115

Description

  • Use the filterable and sortable config values from field config to determine what options to display for a column.
  • Improve stye of column options dialog

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@nicwells nicwells requested a review from smitfire April 13, 2022 12:26
@dhaneshnm dhaneshnm merged commit 4bae079 into 1.7.1 Apr 26, 2022
@dhaneshnm dhaneshnm deleted the 3184-honour-filterable-flag branch April 26, 2022 08:33
dhaneshnm pushed a commit that referenced this pull request May 20, 2022
* Use the newly added explicit sortable/filterable field config values

Previously was using the format field to determine this

* Style improvements to column menu
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants