Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking icon in search config opens select #1081

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

nicwells
Copy link
Contributor

Fixes BlueBrain/nexus#3179

Description

Fix issue where clicking icon in the search config select form item would not open the select menu.

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (1.7.1@7fdd259). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             1.7.1    #1081   +/-   ##
========================================
  Coverage         ?   66.61%           
========================================
  Files            ?       22           
  Lines            ?      668           
  Branches         ?      144           
========================================
  Hits             ?      445           
  Misses           ?      223           
  Partials         ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fdd259...ee3d251. Read the comment docs.

@nicwells nicwells requested a review from smitfire April 22, 2022 07:23
@smitfire smitfire merged commit 288471e into 1.7.1 Apr 25, 2022
@smitfire smitfire deleted the 3179-searchconfig-clickable-icon branch April 25, 2022 05:30
dhaneshnm added a commit that referenced this pull request May 20, 2022
…ckable-icon"

This reverts commit 288471e, reversing
changes made to 7fdd259.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants