-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.8.0 m3 #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Do not close drawer when button inside confirm dialog clicked * Resource view max width 60% when not in drawer * Update url on resource drawer close * Redesigned resource details view
Redesign Admin view for better usability.
* Links opens in new tab - util method to recognize delta links. - Presentation logic open the link in new tab.
* Include Titillium Web font and specify as primary font * Apply standard styling Co-authored-by: Dhanesh Neela Mana <dhanesh.neelamana@epfl.ch>
Co-authored-by: Dhanesh Neela Mana <dhanesh.neelamana@epfl.ch>
* Create resource functionality restored
* Support react.path being an array as supported by react-router react-router supports specifying multiple paths for a specified route by passing an array. Modify fusion code to also support this such that we can take advantage. Specifying multiple paths for a single route allows us to specify multiple paths for a single component without the component remounting when the path changes. * Allow user to select view to target for query
Co-authored-by: Dhanesh Neela Mana <dhanesh.neelamana@epfl.ch>
* Use Resource end point for studio listing Use resource end point to fetch the global list of studios.
Also specify ttf font file type separately to fix issue where path included public/public Co-authored-by: Dhanesh Neela Mana <dhanesh.neelamana@epfl.ch>
Co-authored-by: Dhanesh Neela Mana <dhanesh.neelamana@epfl.ch>
* Styling improvements CopyIcon, InfoIcon white colour Drop shadow on list items Override antd tag blue colour Use component background colour for tabs Remove background colour from search header Remove surplus Manage Studios button Remove gradient from list items Search bar styling Fix font in dev * Fix deep scan issues Co-authored-by: Dhanesh Neela Mana <dhanesh.neelamana@epfl.ch>
Co-authored-by: Dhanesh Neela Mana <dhanesh.neelamana@epfl.ch>
* Disable data cart download button when no perms * Specify correct version of nexus sdk and react nexus packages Co-authored-by: Dhanesh Neela Mana <dhanesh.neelamana@epfl.ch>
Co-authored-by: Dhanesh Neela Mana <dhanesh.neelamana@epfl.ch>
* Date support in search Support date data type in sorting and filtering in search
* Create organization error message * Creating Project error message * Implement missing deprecate project functionality
* Use data table component in Studios instead of sparql view directly * Enable specifying a projection or all projections * New studios are created with new components. Existing studios continue to use old components but will display message prompting to upgrade. * A script will be made available to migrate old studios to new studios or alternatively the user can manually create a new studio Co-authored-by: Dhanesh Neela Mana <dhanesh.neelamana@epfl.ch>
* Fix array values
* Search Layouts with visible fields (and order) along with sorting
* Add redirect params to login call back
* Fix styles for sparql-editor - Remove form logic. - Remove style from form item.
* fix scroll issue Co-authored-by: Dhanesh Neela Mana <dhanesh.n.m19@gmail.com>
* Use the newly added explicit sortable/filterable field config values Previously was using the format field to determine this * Style improvements to column menu
* checking for both aggregate and non aggregate
3039 jira discussions
…r handling and only show plugin when enabled (#1095) * Update default field names * Use self url * Only show jira when plugin enabled in delta * Update error handling to match how Delta now does it * Better error handling * Update property names to reflect change to self
This reverts commit 0c8b76a.
smitfire
previously approved these changes
May 20, 2022
Issue to do with parsing response in sdk. Handle via native fetch for now
Codecov Report
@@ Coverage Diff @@
## main #1105 +/- ##
==========================================
+ Coverage 67.07% 68.75% +1.67%
==========================================
Files 21 14 -7
Lines 568 528 -40
Branches 126 125 -1
==========================================
- Hits 381 363 -18
+ Misses 187 165 -22
Continue to review full report at Codecov.
|
nicwells
approved these changes
May 23, 2022
smitfire
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How has this been tested?
Types of changes
Checklist: