Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Preview download plugins - keep original filenames and fix error - #1107

Merged
dhaneshnm merged 2 commits into
1.8.0-M3from
3244-preview-download-keep-original-filename
May 23, 2022
Merged

dhaneshnm merged 2 commits into
1.8.0-M3from
3244-preview-download-keep-original-filename

Conversation

@nicwells

@nicwells nicwells commented May 23, 2022 •

Copy link
Copy Markdown
Contributor

Fixes BlueBrain/nexus#3218, BlueBrain/nexus#3244

Description

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

nicwells added 2 commits May 23, 2022 11:09
Issue to do with parsing response in sdk. Handle via native fetch for now
@dhaneshnm
dhaneshnm self-requested a review May 23, 2022 12:37
@dhaneshnm
dhaneshnm merged commit 529eeb2 into 1.8.0-M3 May 23, 2022
@dhaneshnm
dhaneshnm deleted the 3244-preview-download-keep-original-filename branch May 23, 2022 12:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants