Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Conversation

@dhaneshnm
Copy link
Contributor

@dhaneshnm dhaneshnm commented May 24, 2022

Fixes BlueBrain/nexus/issues/3288

Description

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@dhaneshnm dhaneshnm requested review from nicwells and smitfire May 24, 2022 07:25
smitfire
smitfire previously approved these changes May 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2022

Codecov Report

Merging #1110 (a22792f) into main (5007a23) will increase coverage by 1.67%.
The diff coverage is 70.83%.

@@            Coverage Diff             @@
##             main    #1110      +/-   ##
==========================================
+ Coverage   67.07%   68.75%   +1.67%     
==========================================
  Files          21       14       -7     
  Lines         568      528      -40     
  Branches      126      125       -1     
==========================================
- Hits          381      363      -18     
+ Misses        187      165      -22     
Impacted Files Coverage Δ
src/shared/store/actions/auth.ts 40.42% <ø> (ø)
src/shared/utils/stringSimilarity.ts 56.25% <22.22%> (-43.75%) ⬇️
src/shared/utils/index.ts 75.00% <77.77%> (+0.96%) ⬆️
src/shared/components/Copy/index.tsx
src/shared/components/Header/index.tsx
src/shared/components/Login/index.tsx
src/shared/utils/copy.ts
src/shared/components/ConsentPreferences/index.tsx

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c88b164...a22792f. Read the comment docs.

@dhaneshnm dhaneshnm requested a review from smitfire May 24, 2022 10:00
@dhaneshnm dhaneshnm merged commit b5c16b2 into main May 24, 2022
@dhaneshnm dhaneshnm deleted the 1.7.1-fix branch May 24, 2022 11:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Studio - failure when adding a new workspace in an empty studio

4 participants