Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save any plugin config on initial studio creation #1115

Merged
merged 1 commit into from
May 27, 2022

Conversation

nicwells
Copy link
Contributor

@nicwells nicwells commented May 27, 2022

Fixes BlueBrain/nexus#3298

Description

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@nicwells nicwells requested a review from dhaneshnm May 27, 2022 07:06
@codecov-commenter
Copy link

Codecov Report

Merging #1115 (b5f18a1) into main (5007a23) will increase coverage by 1.67%.
The diff coverage is 70.83%.

@@            Coverage Diff             @@
##             main    #1115      +/-   ##
==========================================
+ Coverage   67.07%   68.75%   +1.67%     
==========================================
  Files          21       14       -7     
  Lines         568      528      -40     
  Branches      126      125       -1     
==========================================
- Hits          381      363      -18     
+ Misses        187      165      -22     
Impacted Files Coverage Δ
src/shared/store/actions/auth.ts 40.42% <ø> (ø)
src/shared/utils/stringSimilarity.ts 56.25% <22.22%> (-43.75%) ⬇️
src/shared/utils/index.ts 75.00% <77.77%> (+0.96%) ⬆️
src/shared/components/Copy/index.tsx
src/shared/components/Header/index.tsx
src/shared/utils/copy.ts
src/shared/components/Login/index.tsx
src/shared/components/ConsentPreferences/index.tsx

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c346d1...b5f18a1. Read the comment docs.

@nicwells nicwells merged commit 9a4d80a into main May 27, 2022
@nicwells nicwells deleted the 3298-save-studio-plugins-on-creation branch May 27, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Studio: Configuration of plugins when no workspace create isn't saving configuration
3 participants