Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update menu after updating dashboard #1116

Merged
merged 2 commits into from
May 27, 2022

Conversation

nicwells
Copy link
Contributor

Fixes BlueBrain/nexus#3297

Description

Fixes issue where dashboard name is updated but menu item name is not updated

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@nicwells nicwells requested a review from dhaneshnm May 27, 2022 07:45
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2022

Codecov Report

Merging #1116 (95164df) into main (5007a23) will increase coverage by 1.67%.
The diff coverage is 70.83%.

@@            Coverage Diff             @@
##             main    #1116      +/-   ##
==========================================
+ Coverage   67.07%   68.75%   +1.67%     
==========================================
  Files          21       14       -7     
  Lines         568      528      -40     
  Branches      126      125       -1     
==========================================
- Hits          381      363      -18     
+ Misses        187      165      -22     
Impacted Files Coverage Δ
src/shared/store/actions/auth.ts 40.42% <ø> (ø)
src/shared/utils/stringSimilarity.ts 56.25% <22.22%> (-43.75%) ⬇️
src/shared/utils/index.ts 75.00% <77.77%> (+0.96%) ⬆️
src/shared/components/Copy/index.tsx
src/shared/components/Header/index.tsx
src/shared/components/ConsentPreferences/index.tsx
src/shared/utils/copy.ts
src/shared/components/Login/index.tsx

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a4d80a...95164df. Read the comment docs.

@dhaneshnm dhaneshnm merged commit af6f99b into main May 27, 2022
@dhaneshnm dhaneshnm deleted the 3297-update-menu-on-dashboard-save branch May 27, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Studio: Updating the name of a Dashboard isn't reflected in the Workspace menu that list dashboards
3 participants