Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Fix jira error checking condition#1118

Merged
dhaneshnm merged 1 commit intomainfrom
jira-correctly-handle-error-condition
May 27, 2022
Merged

Fix jira error checking condition#1118
dhaneshnm merged 1 commit intomainfrom
jira-correctly-handle-error-condition

Conversation

@nicwells
Copy link
Contributor

Description

Fixes condition in error handling for jira plugin

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@nicwells nicwells requested a review from dhaneshnm May 27, 2022 12:18
@codecov-commenter
Copy link

Codecov Report

Merging #1118 (74af9dc) into main (5007a23) will increase coverage by 1.67%.
The diff coverage is 70.83%.

@@            Coverage Diff             @@
##             main    #1118      +/-   ##
==========================================
+ Coverage   67.07%   68.75%   +1.67%     
==========================================
  Files          21       14       -7     
  Lines         568      528      -40     
  Branches      126      125       -1     
==========================================
- Hits          381      363      -18     
+ Misses        187      165      -22     
Impacted Files Coverage Δ
src/shared/store/actions/auth.ts 40.42% <ø> (ø)
src/shared/utils/stringSimilarity.ts 56.25% <22.22%> (-43.75%) ⬇️
src/shared/utils/index.ts 75.00% <77.77%> (+0.96%) ⬆️
src/shared/components/Copy/index.tsx
src/shared/components/Header/index.tsx
src/shared/components/Login/index.tsx
src/shared/components/ConsentPreferences/index.tsx
src/shared/utils/copy.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6660994...74af9dc. Read the comment docs.

@dhaneshnm dhaneshnm merged commit 5705749 into main May 27, 2022
@dhaneshnm dhaneshnm deleted the jira-correctly-handle-error-condition branch May 27, 2022 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants