Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the JIRA plugin if user is not authenticated with a configurable realm #1119

Merged
merged 3 commits into from
Jun 2, 2022

Conversation

nicwells
Copy link
Contributor

@nicwells nicwells commented Jun 1, 2022

Fixes BlueBrain/nexus#3324

Description

Add ability to specify which realms are supported for Jira. Where realms are specified, if user is not in realm then Jira plugin is not displayed.

How has this been tested?

Tested in local env pointing to staging with the available permutations of specifying a realm or not, user in a Jira supported realm or not

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2022

Codecov Report

Merging #1119 (e1962d1) into main (5007a23) will increase coverage by 1.34%.
The diff coverage is 68.42%.

@@            Coverage Diff             @@
##             main    #1119      +/-   ##
==========================================
+ Coverage   67.07%   68.42%   +1.34%     
==========================================
  Files          21       14       -7     
  Lines         568      532      -36     
  Branches      126      126              
==========================================
- Hits          381      364      -17     
+ Misses        187      168      -19     
Impacted Files Coverage Δ
src/shared/store/actions/auth.ts 40.42% <ø> (ø)
src/shared/utils/stringSimilarity.ts 56.25% <22.22%> (-43.75%) ⬇️
src/shared/utils/index.ts 74.19% <74.62%> (+0.16%) ⬆️
src/shared/components/Copy/index.tsx
src/shared/components/Header/index.tsx
src/shared/components/ConsentPreferences/index.tsx
src/shared/components/Login/index.tsx
src/shared/utils/copy.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5705749...e1962d1. Read the comment docs.

@bogdanromanx bogdanromanx changed the title Jira no show if not logged in to bbp Hide the JIRA plugin if user is not authenticated with a configurable realm Jun 2, 2022
@nicwells nicwells merged commit 03ab697 into main Jun 2, 2022
@nicwells nicwells deleted the jira-no-show-if-not-logged-in-to-bbp branch June 2, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants