2807 admin layout tab update#985
Conversation
Codecov Report
@@ Coverage Diff @@
## 1.7.0-M1 #985 +/- ##
===========================================
Coverage ? 66.31%
===========================================
Files ? 21
Lines ? 576
Branches ? 129
===========================================
Hits ? 382
Misses ? 194
Partials ? 0 Continue to review full report at Codecov.
|
nicwells
left a comment
nicwells
left a comment
There was a problem hiding this comment.
There are a few issues picked up by Deep Scan. Also checking against acceptance criteria:
- Deprecate project button not working so was not able to test acceptance criteria related to this
- Settings button still showing in projects listing
- Clicking on studios/workflows opens in new tab/window but then going back to previous view shows tab with no contents. Possible not to switch to the empty tab when clicked?
|
|
||
| .project-banner { | ||
| background-color: fade(@header-background-color, 2.5%); | ||
| // background-color: fade(@header-background-color, 2.5%); |
There was a problem hiding this comment.
remove rather than comment out
| <div className="project-menu__controls"> | ||
| <Tabs defaultActiveKey="browse" tabPosition="left"> | ||
| <TabPane tab="SparQL" key="browse"> | ||
| <div style={{ flexGrow: 1 }}> |
There was a problem hiding this comment.
styles in separate less file? If copy/paste from elsewhere then can leave
smitfire
force-pushed
the
2807-admin-layout-tab-update
branch
from
d36ace3 to
6db857c
Compare
smitfire
force-pushed
the
2807-admin-layout-tab-update
branch
from
cce4d3f to
7a9e94f
Compare
|
@nicwells removed settings button, likewise for deprecated. made the change for clicking studio or workflows |
Redesign Admin view for better usability.
4 participants
Fixes #
Description
Updated the project admin view to include a few more options. Permissions are now combined with settings (previously only accessible from projects list view).
Statistics and Querying is also now in a separate tab and does not follow an external link.
Studios, Workflow links are embedded in the tab layout but go to the original page via new browser tab.
Create upload moved to new tab, no changes to component.
How has this been tested?
Dev and local environment using the compositepoc org and all of the projects within it.
I have removed the banners from the query, stats, settings components because it is now redundant.
Types of changes
Checklist: