Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2709 redesign resource view #986

Merged
merged 6 commits into from
Nov 5, 2021
Merged

Conversation

nicwells
Copy link
Contributor

@nicwells nicwells commented Nov 4, 2021

Fixes BlueBrain/nexus#2709 and BlueBrain/nexus#2767

Description

Redesign resources view and make better use of side panel. Also fix bug where the ui didn't prevent editing of previous revisions of a resource.

How has this been tested?

Tested the functionality against the acceptance criteria in chrome.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@dhaneshnm dhaneshnm changed the base branch from main to 1.7.0-M1 November 4, 2021 08:23
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2021

Codecov Report

❗ No coverage uploaded for pull request base (1.7.0-M1@fbd4bac). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             1.7.0-M1     #986   +/-   ##
===========================================
  Coverage            ?   66.31%           
===========================================
  Files               ?       21           
  Lines               ?      576           
  Branches            ?      129           
===========================================
  Hits                ?      382           
  Misses              ?      194           
  Partials            ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbd4bac...3158968. Read the comment docs.

@nicwells nicwells marked this pull request as ready for review November 4, 2021 12:20
@dhaneshnm dhaneshnm merged commit 528f183 into 1.7.0-M1 Nov 5, 2021
@dhaneshnm dhaneshnm deleted the 2709-redesign-resource-view branch November 5, 2021 09:04
dhaneshnm pushed a commit that referenced this pull request Mar 11, 2022
* Do not close drawer when button inside confirm dialog clicked

* Resource view max width 60% when not in drawer

* Update url on resource drawer close

* Redesigned resource details view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants