Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent search table header controls from overflowing onto new line #987

Merged

Conversation

nicwells
Copy link
Contributor

@nicwells nicwells commented Nov 4, 2021

Fixes BlueBrain/nexus#2931

Description

Prevent search header options and pagination overflowing onto new line and looking weird when browser window width reduced such that there isn't enough room for all controls.

Screenshot 2021-11-04 at 13 58 56

How has this been tested?

Tested in Chrome

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (1.7.0-M1@fbd4bac). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             1.7.0-M1     #987   +/-   ##
===========================================
  Coverage            ?   67.07%           
===========================================
  Files               ?       21           
  Lines               ?      568           
  Branches            ?      126           
===========================================
  Hits                ?      381           
  Misses              ?      187           
  Partials            ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbd4bac...6263a3a. Read the comment docs.

@dhaneshnm dhaneshnm merged commit ab55407 into 1.7.0-M1 Nov 5, 2021
@dhaneshnm dhaneshnm deleted the 2931-search-table-header-controls-overflow-to-new-line branch November 5, 2021 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants