Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

2932 Prevent Resource side drawer from closing when it shouldn't#988

Merged
dhaneshnm merged 1 commit into1.7.0-M1from
2932-resource-side-drawer-closes-when-shouldnt-bug
Nov 8, 2021
Merged

2932 Prevent Resource side drawer from closing when it shouldn't#988
dhaneshnm merged 1 commit into1.7.0-M1from
2932-resource-side-drawer-closes-when-shouldnt-bug

Conversation

@nicwells
Copy link
Copy Markdown
Contributor

@nicwells nicwells commented Nov 5, 2021

Fixes BlueBrain/nexus#2932

Description

Fix bug where clicking on some ui elements within resource view results in the side drawer closing unexpectedly.

How has this been tested?

Tested with various resources and various plugins.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 5, 2021

Codecov Report

❗ No coverage uploaded for pull request base (1.7.0-M1@528f183). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             1.7.0-M1     #988   +/-   ##
===========================================
  Coverage            ?   66.31%           
===========================================
  Files               ?       21           
  Lines               ?      576           
  Branches            ?      129           
===========================================
  Hits                ?      382           
  Misses              ?      194           
  Partials            ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 528f183...2d6f6f7. Read the comment docs.

@dhaneshnm dhaneshnm merged commit ea16f5e into 1.7.0-M1 Nov 8, 2021
@dhaneshnm dhaneshnm deleted the 2932-resource-side-drawer-closes-when-shouldnt-bug branch November 8, 2021 09:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants