This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Changing filter value triggers on finish automatically vs apply button#990
Merged
Changing filter value triggers on finish automatically vs apply button#990
Conversation
ce2ba0d to
06e7401
Compare
Codecov Report
@@ Coverage Diff @@
## 1.7.0-M2 #990 +/- ##
===========================================
Coverage ? 66.00%
===========================================
Files ? 21
Lines ? 609
Branches ? 137
===========================================
Hits ? 402
Misses ? 207
Partials ? 0 Continue to review full report at Codecov.
|
a48e98a to
d17487a
Compare
dhaneshnm
approved these changes
Nov 19, 2021
dhaneshnm
approved these changes
Nov 23, 2021
e3da84c to
e8f7e30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Search view's filter component used to trigger changes when 'apply' button was clicked. Now changes are triggered on changes to filter component.
Also, adjusted styles so count is far right aligned on the same row.
Description
How has this been tested?
Tested by using relevant part of application
Local developer environment using dev.nexus elastic search endpoints.
Types of changes
Checklist: