Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing filter value triggers on finish automatically vs apply button #990

Merged
merged 10 commits into from
Nov 24, 2021

Conversation

smitfire
Copy link
Contributor

@smitfire smitfire commented Nov 8, 2021

Screenshot 2021-11-08 at 13 08 23

Fixes #
Search view's filter component used to trigger changes when 'apply' button was clicked. Now changes are triggered on changes to filter component.
Also, adjusted styles so count is far right aligned on the same row.

Description

How has this been tested?

Tested by using relevant part of application

Local developer environment using dev.nexus elastic search endpoints.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • [x ] I have added screenshots (if applicable), in the comment section.

@smitfire smitfire changed the title 2897 auto trigger filters Changing filter value triggers on finish automatically vs apply button Nov 8, 2021
@dhaneshnm dhaneshnm changed the base branch from main to 1.7.0-M1 November 8, 2021 13:05
@dhaneshnm dhaneshnm requested review from dhaneshnm and nicwells and removed request for dhaneshnm November 8, 2021 13:08
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2021

Codecov Report

❗ No coverage uploaded for pull request base (1.7.0-M2@45a77bb). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head e3da84c differs from pull request most recent head e8f7e30. Consider uploading reports for the commit e8f7e30 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             1.7.0-M2     #990   +/-   ##
===========================================
  Coverage            ?   66.00%           
===========================================
  Files               ?       21           
  Lines               ?      609           
  Branches            ?      137           
===========================================
  Hits                ?      402           
  Misses              ?      207           
  Partials            ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45a77bb...e8f7e30. Read the comment docs.

@dhaneshnm dhaneshnm changed the base branch from 1.7.0-M1 to 1.7.0-M2 November 12, 2021 11:05
@dhaneshnm dhaneshnm self-requested a review November 23, 2021 13:05
@dhaneshnm dhaneshnm merged commit 9ee983a into 1.7.0-M2 Nov 24, 2021
@dhaneshnm dhaneshnm deleted the 2897-auto-trigger-filters branch November 24, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants