Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

2890 align styling in fusion#991

Merged
dhaneshnm merged 3 commits into1.7.0-M1from
2890-align-styling-in-fusion
Nov 11, 2021
Merged

2890 align styling in fusion#991
dhaneshnm merged 3 commits into1.7.0-M1from
2890-align-styling-in-fusion

Conversation

@nicwells
Copy link
Copy Markdown
Contributor

@nicwells nicwells commented Nov 9, 2021

Fixes BlueBrain/nexus#2890

Description

  • Defines global styles for Fusion including font and colors following the BBP Front-end Style Guide where possible.

  • Titillium Web font included in build so should always be available. Fallback fonts remain as they were and may get used prior to font Titillium Web font loading

  • The following font sizes are defined:

    @fusion-base-font-size: 14px;
    @fusion-heading-1-size: 28px;
    @fusion-heading-2-size: 23px;
    @fusion-heading-3-size: 19px;
    @fusion-heading-4-size: 16px;
    @fusion-heading-5-size: 14px;

Screenshots illustrating the style changes are shown below. Note some components will need some restyling.

Home
Organizations_listing
Organization-new
Admin
Sparql-editor
Workflows-main-view
Workflows-listing

Studio
Workflows-data-table

Search
Search-hidden-columns
Searchbar

How has this been tested?

Navigating different pages of the application and observing styling.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 9, 2021

Codecov Report

❗ No coverage uploaded for pull request base (1.7.0-M1@7407716). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             1.7.0-M1     #991   +/-   ##
===========================================
  Coverage            ?   66.83%           
===========================================
  Files               ?       21           
  Lines               ?      597           
  Branches            ?      137           
===========================================
  Hits                ?      399           
  Misses              ?      198           
  Partials            ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7407716...c30e0f3. Read the comment docs.

@nicwells nicwells changed the base branch from main to 1.7.0-M1 November 9, 2021 08:32
@nicwells nicwells marked this pull request as ready for review November 10, 2021 11:59
@nicwells nicwells force-pushed the 2890-align-styling-in-fusion branch from ed1c18d to 4ac85e3 Compare November 10, 2021 12:21
@dhaneshnm dhaneshnm merged commit 6112507 into 1.7.0-M1 Nov 11, 2021
@dhaneshnm dhaneshnm deleted the 2890-align-styling-in-fusion branch November 11, 2021 15:48
dhaneshnm pushed a commit that referenced this pull request Mar 11, 2022
* Include Titillium Web font and specify as primary font

* Apply standard styling

Co-authored-by: Dhanesh Neela Mana <dhanesh.neelamana@epfl.ch>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align styling in Fusion

3 participants