Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Conversation

@smitfire
Copy link
Contributor

@smitfire smitfire commented Nov 23, 2021

screens:

Screenshot 2021-11-23 at 16 51 33
Screenshot 2021-11-23 at 16 51 39
Screenshot 2021-11-23 at 16 51 45

Fixes #

When a filter is active on a column, a button shows to "Clear filter" and when clicked, remove that column filter and updates the filter menu in the search header (-1 on number of active filters)

Description

When un-selecting every choice in the column dropdown filter, and clicking "Apply", the filter is still considered "active". This has been fixed

How has this been tested?

Acceptance criteria testing by using on Brain Region column, name column, type column. Some of the columns were not testable because of crashing page on fitler bug.

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • [ x] I have added screenshots (if applicable), in the comment section.

@smitfire smitfire changed the base branch from main to 1.7.0-M2 November 23, 2021 15:49
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2021

Codecov Report

❗ No coverage uploaded for pull request base (1.7.0-M2@9ee983a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             1.7.0-M2     #996   +/-   ##
===========================================
  Coverage            ?   66.00%           
===========================================
  Files               ?       21           
  Lines               ?      609           
  Branches            ?      137           
===========================================
  Hits                ?      402           
  Misses              ?      207           
  Partials            ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ee983a...1b30aea. Read the comment docs.

@dhaneshnm dhaneshnm requested a review from nicwells November 24, 2021 08:41
@dhaneshnm dhaneshnm self-requested a review November 24, 2021 08:41
@dhaneshnm dhaneshnm changed the base branch from 1.7.0-M2 to 1.7.0-M3 November 24, 2021 10:00
@dhaneshnm dhaneshnm merged commit af8b5f8 into 1.7.0-M3 Nov 24, 2021
@dhaneshnm dhaneshnm deleted the 2784-filter-remove branch November 24, 2021 10:00
dhaneshnm pushed a commit that referenced this pull request Dec 14, 2021
Co-authored-by: Dhanesh Neela Mana <dhanesh.neelamana@epfl.ch>
dhaneshnm pushed a commit that referenced this pull request Mar 11, 2022
Co-authored-by: Dhanesh Neela Mana <dhanesh.neelamana@epfl.ch>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants