This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Conversation
nicwells
force-pushed
the
2926-disable-data-cart-download-button-when-no-permissions
branch
from
November 24, 2021 08:34
c12b476 to
31196e3
Compare
nicwells
marked this pull request as draft
November 24, 2021 08:34
dhaneshnm
approved these changes
Nov 24, 2021
nicwells
force-pushed
the
2926-disable-data-cart-download-button-when-no-permissions
branch
from
December 8, 2021 14:50
31196e3 to
b66c6df
Compare
nicwells
marked this pull request as ready for review
December 8, 2021 14:51
Codecov Report
@@ Coverage Diff @@
## 1.7.0-M3 #997 +/- ##
===========================================
Coverage ? 66.00%
===========================================
Files ? 21
Lines ? 609
Branches ? 126
===========================================
Hits ? 402
Misses ? 207
Partials ? 0 Continue to review full report at Codecov.
|
dhaneshnm
approved these changes
Dec 9, 2021
added 2 commits
December 9, 2021 08:58
…hen-no-permissions
…hen-no-permissions
dhaneshnm
deleted the
2926-disable-data-cart-download-button-when-no-permissions
branch
December 13, 2021 08:11
dhaneshnm
pushed a commit
that referenced
this pull request
Mar 11, 2022
* Disable data cart download button when no perms * Specify correct version of nexus sdk and react nexus packages Co-authored-by: Dhanesh Neela Mana <dhanesh.neelamana@epfl.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes BlueBrain/nexus#2926
Description
Disables download button if user doesn't have the required permissions to download all the resources in their cart.
Note: requires the updated AccessControl component in the react-nexus package, BlueBrain/nexus-js#369
How has this been tested?
Types of changes
Checklist: