Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Replace placeholder arg_v with the correct name in function containin… #768

Merged
merged 4 commits into from
Nov 9, 2021
Merged

Replace placeholder arg_v with the correct name in function containin… #768

merged 4 commits into from
Nov 9, 2021

Conversation

@alkino
Copy link
Member

@alkino alkino commented Nov 3, 2021 •
edited
Loading

…g table stmt

Fixing:

PROCEDURE settables(b) {
    TABLE minf FROM 1 TO 2 WITH 1
    minf = 0
}

Checking that the following construct is not valid because PROCEDURE with TABLE statement should have exactly one parameter.

PROCEDURE settables(a, b) {
    TABLE <...>
    <...>

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #22833 (:no_entry:) have been uploaded here!

Status and direct links:

@alkino alkino mentioned this pull request Nov 3, 2021
Closed
@alkino alkino force-pushed the arg_v_fix branch 3 times, most recently from 49ad187 to 5f880ff Compare November 3, 2021 09:46
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #22859 (:white_check_mark:) have been uploaded here!

Status and direct links:

@alkino alkino force-pushed the arg_v_fix branch 5 times, most recently from b383e06 to a0323f9 Compare November 3, 2021 10:56
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #22886 (:white_check_mark:) have been uploaded here!

Status and direct links:

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #22894 (:white_check_mark:) have been uploaded here!

Status and direct links:

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #22906 (:white_check_mark:) have been uploaded here!

Status and direct links:

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #22939 (:white_check_mark:) have been uploaded here!

Status and direct links:

pramodk
pramodk reviewed Nov 4, 2021
View reviewed changes
pramodk
pramodk reviewed Nov 4, 2021
View reviewed changes
Replace placeholder arg_v with the correct name in function containin…
9525960 
…g table stmt

The last argument is often called `v` and is renamed to `arg_v`.
This fix let user choose a different name.
@alkino alkino marked this pull request as ready for review November 4, 2021 13:10
@codecov-commenter
Copy link

Codecov Report

Merging #768 (5666abb) into master (dba5903) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 5666abb differs from pull request most recent head 9525960. Consider uploading reports for the commit 9525960 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   59.82%   59.81%   -0.01%     
==========================================
  Files         200      200              
  Lines       37143    37147       +4     
==========================================
  Hits        22221    22221              
- Misses      14922    14926       +4
Impacted Files Coverage Δ
src/codegen/codegen_c_visitor.cpp 63.12% <0.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dba5903...9525960. Read the comment docs.

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #23082 (:white_check_mark:) have been uploaded here!

Status and direct links:

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #23104 (:white_check_mark:) have been uploaded here!

Status and direct links:

pramodk
pramodk approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #23122 (:white_check_mark:) have been uploaded here!

Status and direct links:

@pramodk
Fix mod files
7926d21 
 - TABLE statement with non-local variable
 - DESTRUCTOR can be used only in POINT_PROCESS mod file
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #23717 (:no_entry:) have been uploaded here!

Status and direct links:

@olupton olupton closed this Nov 9, 2021
@olupton olupton reopened this Nov 9, 2021
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #23828 (:white_check_mark:) have been uploaded here!

Status and direct links:

@alkino alkino merged commit 55e4a6f into master Nov 9, 2021
@alkino alkino deleted the arg_v_fix branch November 9, 2021 12:26
JCGoran pushed a commit to neuronsimulator/nrn that referenced this pull request Mar 12, 2025
Replace placeholder arg_v with the correct name in function containin… (
6d3f15e 
BlueBrain/nmodl#768)

The last argument is often called `v` and is renamed to `arg_v`.
This fix let user choose a different name.

Co-authored-by: Pramod Kumbhar <pramod.s.kumbhar@gmail.com>

NMODL Repo SHA: BlueBrain/nmodl@55e4a6f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@pramodk pramodk pramodk approved these changes

@iomaganaris iomaganaris iomaganaris approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@alkino @bbpbuildbot @codecov-commenter @pramodk @iomaganaris @olupton