From 87932ea73055d81ec45c6f81b714ce203eb559a3 Mon Sep 17 00:00:00 2001 From: Michael Jackson Date: Mon, 5 Oct 2015 11:22:43 -0400 Subject: [PATCH] Fixing compile errors due to unprintable ASCII character. --- .../OrientationLib/OrientationMath/OrientationTransforms.hpp | 2 +- Source/OrientationLib/Test/OrientationTransformsTest.cpp | 1 - .../OrientationAnalysisFilters/ConvertOrientations.md | 4 ++-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/Source/OrientationLib/OrientationMath/OrientationTransforms.hpp b/Source/OrientationLib/OrientationMath/OrientationTransforms.hpp index ec9c8eed96..277a75cefb 100644 --- a/Source/OrientationLib/OrientationMath/OrientationTransforms.hpp +++ b/Source/OrientationLib/OrientationMath/OrientationTransforms.hpp @@ -358,7 +358,7 @@ class OrientationTransforms T out = OMHelperType::multiply(ro, ro, 3); K ttl = OMHelperType::sum(out); ttl = sqrt(ttl); - if (fabs(ttl - 1.0L) > eps) + if (fabs(ttl - 1.0) > eps) { res.msg = "rotations:ro_check:: Rodrigues-Frank axis vector not normalized"; res.result = -2; diff --git a/Source/OrientationLib/Test/OrientationTransformsTest.cpp b/Source/OrientationLib/Test/OrientationTransformsTest.cpp index 86ea133e0f..90cba79d19 100644 --- a/Source/OrientationLib/Test/OrientationTransformsTest.cpp +++ b/Source/OrientationLib/Test/OrientationTransformsTest.cpp @@ -649,7 +649,6 @@ void StartTest() { // RunTestCase(entry, 16); RunTestCase(entry, 16); -   } } } diff --git a/Source/Plugins/OrientationAnalysis/Documentation/OrientationAnalysisFilters/ConvertOrientations.md b/Source/Plugins/OrientationAnalysis/Documentation/OrientationAnalysisFilters/ConvertOrientations.md index 4513f0273e..80819b7ceb 100644 --- a/Source/Plugins/OrientationAnalysis/Documentation/OrientationAnalysisFilters/ConvertOrientations.md +++ b/Source/Plugins/OrientationAnalysis/Documentation/OrientationAnalysisFilters/ConvertOrientations.md @@ -32,9 +32,9 @@ If the angles fall outside of this range the **original** Euler Input data **WIL | Cubochoric | 3 | 5 | **Not Yet Implemented** | -#### Precision Notes ### +## Precision Notes ## -While every effort has been made to ensure the correctness of each transformation algorithm certain situations may arise where the initial precision of the input data is not large enough for the algorithm to calculate an answer that is intuitive. The user should be acutely aware of their input data and if their data may cause these situations to occur. Combinations of Euler angles close to 0, 180 and 360 can cause these issues to be hit. For instance an Euler angle of [180, 56, 360] is symmetrically the same as [180, 56, 0] and due to calculation errors and round off errors converting that Euler angle between representations may not give the numerical answer the user was anticipating but will give a symmetrically equivalent angle. +While every effort has been made to ensure the correctness of each transformation algorithm, certain situations may arise where the initial precision of the input data is not large enough for the algorithm to calculate an answer that is intuitive. The user should be acutely aware of their input data and if their data may cause these situations to occur. Combinations of Euler angles close to 0, 180 and 360 can cause these issues to be hit. For instance an Euler angle of [180, 56, 360] is symmetrically the same as [180, 56, 0] and due to calculation errors and round off errors converting that Euler angle between representations may not give the numerical answer the user was anticipating but will give a symmetrically equivalent angle. ## Parameters ##