Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bip47 & Reusable Payment Codes version 3 & 4 #2883

Open
yoshimo opened this issue Mar 30, 2021 · 122 comments
Open

Bip47 & Reusable Payment Codes version 3 & 4 #2883

yoshimo opened this issue Mar 30, 2021 · 122 comments

Comments

@yoshimo
Copy link

yoshimo commented Mar 30, 2021

Since we are getting closer to TOR Support, it would be great to get additional support for privacy enhancing features.
Colloquial, PayNyms.
These are specified in Bip47 as implemented by Samourai and enhanced in https://github.com/OpenBitcoinPrivacyProject/rfc/blob/master/obpp-05.mediawiki
Having more wallets support this venmo style method for sending money to your friends, would benefit the ecosystem in general.

@yoshimo
Copy link
Author

yoshimo commented Oct 7, 2021

150k Sats for an implementation

@yoshimo
Copy link
Author

yoshimo commented Dec 16, 2021

@Overtorment could you add the bounty-label?

@ghost
Copy link

ghost commented Feb 17, 2022

Count me in for another 850k sats

@acantril
Copy link

Count me in for 1 million sats

@dav1dpgit
Copy link

In for 100k sats

@ghost
Copy link

ghost commented Feb 17, 2022

This could be huge. In for 100k sats.

@coinsurenz
Copy link

1 million sats to this worthy cause

@modl21
Copy link

modl21 commented Feb 17, 2022

count me in for a million sats

@RequestPrivacy
Copy link

Not a fan of iOS but it will help Bitcoin so 25,000 sats from me.


Total bounty: 4.250.000 sats

@ghost
Copy link

ghost commented Feb 17, 2022

Another 250k from @Jorj_X_McKie on Twitter

https://twitter.com/Jorj_X_McKie/status/1494366711709159430?s=20&t=vKlwZaVyPHEg5kiKgPg4Xg


Total bounty: 4,500,000 SATs

@ghost
Copy link

ghost commented Feb 17, 2022

Member of Citadel Dispatch matrix group pledged another 1 million sats

Screen Shot 2022-02-17 at 10 41 55


Total bounty: 5,500,000 SATs

@Ziya-Sadr
Copy link
Contributor

count me in for 100k sats

@apemithrandir
Copy link

500k Sats

@btcuserguide
Copy link

i'm in for 1,000,000

@BTclaudia
Copy link

I'm down for 500k SATs

@ion497
Copy link

ion497 commented Feb 20, 2022

Count me in for 200k sats

@ghost
Copy link

ghost commented Feb 20, 2022

Another 300k from @Does_not_mattr on Twitter

https://twitter.com/Does_not_mattr/status/1495321573208858625


Total bounty: 8,100,000 SATs

@jamesgmorgan
Copy link

I pledge 125K sats donated over paynym upon completion.

@ghost
Copy link

ghost commented Feb 20, 2022

Another 100k from Meister Eder on Twitter

https://twitter.com/Meister_Ancap/status/1495473258258382850


Total bounty: 8,525,000 SATs

@diegoperezcham
Copy link

Count me in for 475K sats

@TheGuySwann
Copy link

Put me down for 1,000,000 sats to make it an even 10 👍🏻

@alaznem
Copy link

alaznem commented Feb 20, 2022

count me in for 40k sat

@FreddyPPFinklemeyerIII
Copy link

I’m in for 1,000,000 million sats

@ghost
Copy link

ghost commented Feb 21, 2022

Another 500k from Isaiah Douglass, MBA, CFP on Twitter

https://twitter.com/IDFinancial/status/1495503166133215232


Total bounty: 11,500,040 SATs

@ghost
Copy link

ghost commented Feb 21, 2022

Another 300k from AmBird on Twitter

https://twitter.com/TurboSloth1869/status/1495554918656233472


Total bounty: 11,800,040 SATs

@ghost
Copy link

ghost commented Feb 21, 2022

Another 100k from Honk Honk MetaMick on Twitter

https://twitter.com/metamick14/status/1495850492978733062


Total bounty: 11,900,040 SATs

@apemithrandir
Copy link

Just loaded up the apk from the PR and got myself a blue wallet payment code. Once I get some sats on the wallet I will pay that bounty.
Next step is to link BlueWallet up with http://paynym.is and get me my little robot avatar 👍
Also managed to connect to my own node before generating the wallet for that extra touch of class.

Any plans to add any of these features that Sparrow has:
https://sparrowwallet.com/docs/spending-privately.html
Such as collaborative transactions etc?

@apemithrandir
Copy link

How do I use BlueWallet to send to @abhiShandy 's payment code?

@abhishandilya
Copy link

You can't send using payment codes, just receive from it right now

@apemithrandir
Copy link

apemithrandir commented Mar 19, 2023

You can't send using payment codes, just receive from it right now

I guess it wasn't explicitly stated anywhere in the thread above but I was assuming sending and receiving via payment codes. I will send half of the 1m Sats I pledged but I won't be able to use BlueWallet to send it to your payment code. I will have to use Sparrow.

I do not know what other bounty pledges will do. We shall see what they assumed a full implementation was.

@apemithrandir
Copy link

Also I am gonna have to put an expiration date on the remaining 500k of my bounty: Block Height 807,708 (approx 6 months)

Can't be leaving a Bitcoin denominated liability out there with no time limit!

@abhiShandy
Copy link
Contributor

Sorry for the confusion. This is the first iteration. Sending should be implemented in the next one. Having an expiration date is a good idea. This GitHub issue has been lingering for too long.

Thanks for sending half of your pledge.

@coinsurenz
Copy link

Haven't been able to keep up with developments here but understand this is in beta? once deployed for all and sundry please tag me here & dm/mention on twitter (same handle) if you dont get a prompt response as my github notifications tend to be pretty cluttered

@jordan-bravo
Copy link

Subscribing to this issue to be notified of updates.

@apemithrandir
Copy link

Also I am gonna have to put an expiration date on the remaining 500k of my bounty: Block Height 807,708 (approx 6 months)

Can't be leaving a Bitcoin denominated liability out there with no time limit!

We have passed the Block Height on my remaining half of my bounty.
Can I confirm that you cannot both send and receive to a payment code?

@abhiShandy
Copy link
Contributor

abhiShandy commented Sep 30, 2023 via email

@yoshimo
Copy link
Author

yoshimo commented Dec 31, 2023

Is there ongoing work on the sending part? I'd send my bounty with BW :)

@mateusdeap
Copy link

Where's the PR for this? Both PRs linked have been closed...

@pointbiz
Copy link

https://twitter.com/BtcCuracao/status/1783705971363025290

19,500,000 sat bounty from me.

@apemithrandir
Copy link

https://twitter.com/BtcCuracao/status/1783705971363025290

19,500,000 sat bounty from me.

This task has become harder. You cannot rely on Soroban communications anymore.

@Overtorment
Copy link
Member

work is being done to add support for sending to barebone payment codes (not paynyms)

@killer21m
Copy link

I was asking for some support with this feature here:

#6663

The only response I've got so far is from a scammer trying to steal my seed.

@apemithrandir
Copy link

This work is completed now, correct?
Who completed the required work?
I may or may not still honor my 500k bounty which expired over 50k blocks ago.

@pointbiz
Copy link

I see this bounty has been fulfilled and I would like to pay it out. Thank you, from all Canadian Truckers!

I understand the developer was: Overtorment
Reviewers: limpbrains, marcosrdz, BenWestgate

Overtorment can you provide a Bitcoin address or payment code?
Reviewers can you provide Lightning addresses?

@sara554-beep

This comment was marked as abuse.

@DeMonkeyCoder
Copy link

Hi
Glad to see this feature is finally merged and live!

This bip47 library developed by @zkfriendly is used in the development of this feature:

import BIP47Factory, { BIP47Interface } from '@spsina/bip47';

So we'd appreciate it if the supporters of the bounty also consider donating some BTC to the donation address provided in the README of the repository 🙂

Thanks for your hard work! @abhiShandy @Overtorment

@Overtorment
Copy link
Member

i also enquired HRF about the bounty, waiting for a reply. If paid out, it will be distributed to everyone involved, starting from the awesome lib author

@pointbiz
Copy link

Hi Glad to see this feature is finally merged and live!

This bip47 library developed by @zkfriendly is used in the development of this feature:

import BIP47Factory, { BIP47Interface } from '@spsina/bip47';

So we'd appreciate it if the supporters of the bounty also consider donating some BTC to the donation address provided in the README of the repository 🙂
Thanks for your hard work! @abhiShandy @Overtorment

Yes! Thank you, I see the address in the readme. My intention is to split my bounty with everyone involved. I will wait to get the addresses from the other developers.

@yoshimo
Copy link
Author

yoshimo commented Sep 16, 2024

i would appreciate payment codes to be listed by the project owners themselfes so nobody can come in and snatch the rewards

@abhiShandy
Copy link
Contributor

Here's my payment code:

PM8TJi7Qfijct7b7mZydJkRUY4WPvg9C5UrGL2LZQf9tThsi5RFDTFZorT4DBbzeom9q6SWvSXtw6B9BQkkcSJ7zzNkeKb9KtiQWJZsJ2LscuG5xk9sc

@Overtorment
Copy link
Member

Overtorment commented Sep 17, 2024

@zkfriendly can you pls post your paymentcode?

upd: he has donation address on his repo here: https://github.com/zkfriendly/bip47

@zkfriendly
Copy link

zkfriendly commented Sep 17, 2024 via email

@DeMonkeyCoder
Copy link

Hi @Overtorment,
Did you also post your payment code somewhere?

@Overtorment
Copy link
Member

PM8TJTSwtBAgeSZjAG7bAEoRaLkD7cvP8sopgEMpG3fm1bxorfLDRk1w1ih2VxS9RGCstuY4mh1dJJr9ckV4mctvqirq14wgCQcdYHuRG5obe5W5QYus

image

@Overtorment
Copy link
Member

Some donations were just distributed.

If anyone pledged sats and havent sent them - please split them between 3 listed payment codes (zkfriendly, abhi, myself)

@pointbiz
Copy link

Some donations were just distributed.

If anyone pledged sats and havent sent them - please split them between 3 listed payment codes (zkfriendly, abhi, myself)

I initially pledged 19,500,000 sats. I decided to donate 16,680,000 sats to each developer zkfriendly, abhiShandy, Overtorment totaling 50,040,000 sats.

I'm super thankful to have this contacts functionality and I'm already using it in the real world. You folks are amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.