Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bob minimum version is checked too late #420

Closed
danielroedl opened this issue Jun 11, 2021 · 1 comment
Closed

Bob minimum version is checked too late #420

danielroedl opened this issue Jun 11, 2021 · 1 comment

Comments

@danielroedl
Copy link
Contributor

Hi,

there is a problem with the config.yaml in context of changes between bob versions.
If there is a new key in the config.yaml or another incompatible change (new policy, struture change) in a new bob version the error is not pointing to the wrong number.

With not known policies the error is (there is a hint to the bob version):
Parse error: Error while validating config.yaml: Invalid policy specified! Maybe your Bob is too old?

With new keys the error is just:
Parse error: Error while validating config.yaml: Wrong key 'Test123' in {'Test123': true, ...

Would it be better to first check the bobMinimumVersion and than validate the everything else?

@jkloetzke
Copy link
Member

I think this makes sense. It will make parsing a bit more difficult but the better error message looks worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants