Skip to content

Change "root" route to "blog_root" to avoid name clash with applications's "root" route #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2013

Conversation

kassi
Copy link

@kassi kassi commented Feb 9, 2013

If you're using

config.inline_main_app_named_routes = true

which you probably want if you add blogit to your existing rails app, then a link in the nab to root got overridden by Blogit::Engine to "/blog" (or whatever you set it to be in your app's routes.rb). That's imho no way to go, because I want links to home page to still point to /.

This patch let's you keep on using root for your home page and adds blog_root to entry point for blogit.

Unfortunately I'm not able to run the tests (via rspec) because of database errors I'm not familiar with.

Bodacious added a commit that referenced this pull request Feb 10, 2013
Change "root" route to "blog_root" to avoid name clash with applications's "root" route
@Bodacious Bodacious merged commit 5e06459 into Bodacious:master Feb 10, 2013
@Bodacious
Copy link
Owner

Good point @kassi - thanks for the patch! 😄

I'll make sure the test suite is running properly and double-check this before I release the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants