Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.7.1.0 is deprecated on Hackage #20

Closed
kquick opened this issue Feb 6, 2021 · 5 comments
Closed

Version 0.7.1.0 is deprecated on Hackage #20

kquick opened this issue Feb 6, 2021 · 5 comments

Comments

@kquick
Copy link
Contributor

kquick commented Feb 6, 2021

For some reason, the (currently) latest version 0.7.1.0 is showing up as deprecated on Hackage (https://hackage.haskell.org/package/logict/preferred) which means Cabal will not use it for satisfying builds.

@Bodigrim
Copy link
Owner

Bodigrim commented Feb 6, 2021

The reason for the deprecation was that the changes I made broke packages downstream, and I wanted to give them time to catch up. But given that 0.7.1.0 made way into Stackage LTS, it is probably a lesser evil to unhide it.

@Bodigrim Bodigrim closed this as completed Feb 6, 2021
@kquick
Copy link
Contributor Author

kquick commented Feb 6, 2021

If it broke downstream, maybe leave 0.7.1.0 as deprecated and release it again under 0.8.0.0 to conform to PVP. Then downstream packages with upper major constraint bounds should be fine as per normal PVP expectations.

@Bodigrim
Copy link
Owner

Bodigrim commented Feb 6, 2021

Unfortunately, it does not make much sense any longer: since logict-0.7.1.0 made way into Stackage LTS (seems it does not check for deprecated status), its version is frozen there for a year or so. Having a package available for stack builds, but not for cabal ones would be bad in a long run.

Practically speaking, downstream packages with upper bounds are unaffected. The only two broken packages do not have upper bounds and need to revise them anyways. They can put < 0.7.1 as easily as < 0.8. I've contacted their maintainers three weeks ago.

All this is obviously caused by my fault and bad judgement, but given circumstances described above I'd rather leave it as is.

@kquick
Copy link
Contributor Author

kquick commented Feb 6, 2021

I wouldn't worry about the blame: it's easy to mis-calculate the impact when determining a new version, which is why the deprecated feature is nice.

I don't use stack so I wasn't aware of the nuance here, but I certainly understand the issue with it already being incorporated in the curated LTS. I agree that in the circumstances it would be awkward to have two different active versions.

Thanks for removing the deprecation to enable it to be picked up by cabal operations!

@phadej
Copy link

phadej commented Aug 11, 2023

I made revision to logict-0.7.1.0, hiding it. Stackage current and previous LTS are using 0.8, and stack will happily use 0.7.1.0 in snapshots, as it pins the revision (i.e. revisions doesn't affect old snapshots).

EDIT: I was looking at build failures in unification-fd and backtracked to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants