Skip to content

Pipeline continue even if the message is marked as failed #151

Closed

Description

@davidt99

I have a middleware that marks certain messages as failed. The pipeline middleware is only looking whether an exception was raised and continue the chain although I had expected it to stop.
Should be an easy fix, let me know if you want me to open a PR to resolve it (if this is the desired behavior).

Activity

  1. Bogdanp commented on Dec 25, 2018

    @Bogdanp
    Owner

    I think I see what you mean. Pipelines does

            if exception is not None:
                return

    whereas that should probably be something along the lines of

            if exception is not None or message.failed:
                return

    Please send a PR (and don't forget to include a test!) if you're up for it!

  2. added this to the v1.4.1 milestone on Dec 25, 2018
  3. added 2 commits that reference this issue on Dec 27, 2018
    742b492
    a066897
  4. added a commit that references this issue on Jun 17, 2025
    34f2922
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions