Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline continue even if the message is marked as failed #151

Closed
davidt99 opened this issue Dec 24, 2018 · 1 comment
Closed

Pipeline continue even if the message is marked as failed #151

davidt99 opened this issue Dec 24, 2018 · 1 comment
Labels
Milestone

Comments

@davidt99
Copy link
Contributor

@davidt99 davidt99 commented Dec 24, 2018

I have a middleware that marks certain messages as failed. The pipeline middleware is only looking whether an exception was raised and continue the chain although I had expected it to stop.
Should be an easy fix, let me know if you want me to open a PR to resolve it (if this is the desired behavior).

@Bogdanp
Copy link
Owner

@Bogdanp Bogdanp commented Dec 25, 2018

I think I see what you mean. Pipelines does

        if exception is not None:
            return

whereas that should probably be something along the lines of

        if exception is not None or message.failed:
            return

Please send a PR (and don't forget to include a test!) if you're up for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants