Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-coded virtual env name #2

Closed
whalesalad opened this issue Oct 29, 2017 · 6 comments
Closed

Hard-coded virtual env name #2

whalesalad opened this issue Oct 29, 2017 · 6 comments
Labels
bug

Comments

@whalesalad
Copy link
Contributor

@whalesalad whalesalad commented Oct 29, 2017

I am not quite sure what is happening, but I am guessing this is due to something in the build/release process?

When I run the dramatiq-gevent binary, I get the following error:

dramatiq-gevent
zsh: /Users/michael/Envs/planet-ingest/bin/dramatiq-gevent: bad interpreter: /Users/bogdan/.virtualenvs/dramatiq/bin/python: no such file or directory

@Bogdanp
Copy link
Owner

@Bogdanp Bogdanp commented Oct 30, 2017

Thanks for the report! It turns out that setuptools rewrites this shebang:

#!/usr/bin/env python

To

#!$VENV_ROOT/dramatiq/bin/python

Once I merge Ben's change, this'll be fixed.

@Bogdanp Bogdanp added the bug label Oct 30, 2017
bendemaree pushed a commit to bendemaree/dramatiq that referenced this issue Oct 30, 2017
@Bogdanp Bogdanp closed this in ec31fe9 Oct 30, 2017
@rakanalh
Copy link
Contributor

@rakanalh rakanalh commented Nov 13, 2017

It seems like 0.11.0 release still has the bug. Could you please mark a new release of the newer fixed version?

@rakanalh
Copy link
Contributor

@rakanalh rakanalh commented Nov 13, 2017

I checked the release on github and it's fixed... however, pypi still has 0.11.0 which has the hard coded version:

➜  Downloads cd dramatiq-0.11.0-py3-none-any
➜  dramatiq-0.11.0-py3-none-any ls -la
total 16
drwx------@  6 rakan  staff   204B Nov 13 22:32 .
drwx------+ 57 rakan  staff   1.9K Nov 13 22:32 ..
-rw-r--r--@  1 rakan  staff   6.0K Nov 13 22:32 .DS_Store
drwxr-xr-x@ 14 rakan  staff   476B Nov 13 22:32 dramatiq
drwxr-xr-x@  3 rakan  staff   102B Nov 13 22:32 dramatiq-0.11.0.data
drwxr-xr-x@  9 rakan  staff   306B Nov 13 22:32 dramatiq-0.11.0.dist-info
➜  dramatiq-0.11.0-py3-none-any grep -irn "bogdan" ./
.//dramatiq-0.11.0.data/scripts/dramatiq-gevent:1:#!/Users/bogdan/.virtualenvs/dramatiq/bin/python
@Bogdanp
Copy link
Owner

@Bogdanp Bogdanp commented Nov 14, 2017

Thanks @rakanalh. It looks like this happens when I build the wheels for distribution. I thought it had been fixed but it only seemed so because I do have a virtualenv called dramatiq :P.

Building a new wheel and then unzipping it does show the problem persists so I'm reopening this issue.

(dramatiq) ~/s/d/dist (master)> head dramatiq-0.11.0.data/scripts/dramatiq-gevent
#!/Users/bogdan/.virtualenvs/dramatiq/bin/python
@Bogdanp Bogdanp reopened this Nov 14, 2017
@Bogdanp Bogdanp closed this in 6e423b8 Nov 14, 2017
@Bogdanp
Copy link
Owner

@Bogdanp Bogdanp commented Nov 14, 2017

Alright, this is fixed in 0.12:

(tempenv-604b214375fe0) ~> head (which dramatiq-gevent)
#!/Users/bogdan/.virtualenvs/tempenv-604b214375fe0/bin/python3.6
@rakanalh
Copy link
Contributor

@rakanalh rakanalh commented Nov 14, 2017

Confirmed... thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.