Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No stacktrace with critical logs from worker #42

Closed
benekastah opened this issue Mar 12, 2018 · 2 comments
Closed

No stacktrace with critical logs from worker #42

benekastah opened this issue Mar 12, 2018 · 2 comments
Assignees
Labels

Comments

@benekastah
Copy link
Contributor

@benekastah benekastah commented Mar 12, 2018

I'm getting the error message "Consumer encountered an error: 'NoneType' object has no attribute 'decode'", but there's no stack trace. How do you feel about adding exc_info=True into the logger.critical call in dramatiq.worker line 217?

As to why the error is happening, I deleted some jobs from the delayed queue and I'm guessing there's still something in redis that knows about them, but I don't know what.

@Bogdanp Bogdanp self-assigned this Mar 16, 2018
@Bogdanp Bogdanp added the enhancement label Mar 16, 2018
@Bogdanp
Copy link
Owner

@Bogdanp Bogdanp commented Mar 16, 2018

As to why the error is happening, I deleted some jobs from the delayed queue and I'm guessing there's still something in redis that knows about them, but I don't know what.

In addition to deleting the hashes, you need to remove the messages from the message list (the queue) and from the acks zset if any of them were in memory. You might've skipped the latter two. Take a look at https://github.com/Bogdanp/dramatiq/blob/master/dramatiq/brokers/redis/ack.lua I assume that's where stuff blows up.

I'll make this change tonight! Thanks for the suggestion.

@benekastah
Copy link
Contributor Author

@benekastah benekastah commented Mar 16, 2018

Ah, thanks for the tip. Looks like that resolved things :)

@Bogdanp Bogdanp closed this in 7feb69d Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.