Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker output is too verbose/worker output utf-8 decode error and hangs #63

Closed
Timaqf opened this issue Apr 10, 2018 · 5 comments
Closed

worker output is too verbose/worker output utf-8 decode error and hangs #63

Timaqf opened this issue Apr 10, 2018 · 5 comments
Labels

Comments

@Timaqf
Copy link

@Timaqf Timaqf commented Apr 10, 2018

at https://github.com/Bogdanp/dramatiq/blob/master/dramatiq/__main__.py#L351
watch_log try to decode output as utf-8 encoding, but when output can't be decoded with utf-8, worker will crash and hangs.

and also worker output is too verbose, it will print all args and kwargs at INFO level by default. maybe it will be more friendly when it's in DEBUG level ?

@Bogdanp
Copy link
Owner

@Bogdanp Bogdanp commented Apr 10, 2018

Re. decoding errors, that's interesting. What are you logging?

and also worker output is too verbose, it will print all args and kwargs at INFO level by default. maybe it will be more friendly when it's in DEBUG level ?

I'm split on this. On the one hand, I can see how it'd be annoying if you have large arguments, but on the other, I don't think you should have to turn debug logging on just to see that your actors are actually doing something. I'll have to think about it more. Maybe it may make sense to truncate large messages somehow.

@Timaqf
Copy link
Author

@Timaqf Timaqf commented Apr 11, 2018

maybe we should have verbose levels

@Bogdanp
Copy link
Owner

@Bogdanp Bogdanp commented Apr 12, 2018

Would you mind creating a minimal reproducible example that shows the failure you saw?

@Timaqf
Copy link
Author

@Timaqf Timaqf commented Apr 13, 2018

@Bogdanp
sorry,
I don't have examples, because that time it's crashed and I'm sure It's occurred at the line I mentioned.
https://github.com/Bogdanp/dramatiq/blob/master/dramatiq/__main__.py#L351

you can close this issue, and when I meet it next time, I will reopen it with the code.

@Bogdanp Bogdanp closed this in f14d46c Apr 14, 2018
@nathanmkaya
Copy link

@nathanmkaya nathanmkaya commented Jan 17, 2019

@Timaqf did you find a workaround for this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.