Runtime error when using `@actor` decorator in interactive shell with a locally defined function

[bartvanandel]

I was debugging some of our own code in an interactive Python shell, and ran into a runtime type error with the @actor decorator:

TypeError: unsupported operand type(s) for +=: 'NoneType' and 'str'

The error is caused by this line, which fails with locally defined, non module-bound functions:

dramatiq/dramatiq/actor.py

Line 70 in 6d60a5f

self.logger = get_logger(fn.__module__, actor_name)

It's definitely an edge case, but this simple change fixes it:

self.logger = get_logger(fn.__module__ or '_', actor_name)

[synweap15]

Hey @bartvanandel, this indeed looks like an edge case that can cause problems. Nevertheless, your fix makes sense and is pocket-sized. Feel free to put up a PR.

[bartvanandel]

@synweap15 PR is ready for inspection.

[synweap15]

@bartvanandel lgtm, we're waiting for #697 as currently we can't run CI jobs.

[synweap15]

@bartvanandel all good now, please just rebase on top of current master or just merge master to your branch to pull the CI settings changes. Thanks!