Skip to content

dramatiq should work with python >= 3.4. #7

Closed

Description

@jssuzanne

Hi,

Actually dramatiq works only with python 3.6 and 3.7a. the linux distribution haven't got theses versions of python. Why don't you keep the capability to use use Python 3.4 and highter

Activity

  1. jssuzanne commented on Nov 15, 2017

    @jssuzanne
    ContributorAuthor

    I have started, the implementation in the branch.

    For python 3.5, it is easy I have juste replaced print(f"{}") by print("%s" % ...) .
    Python 3.4 is harder, yield from does not work with pip install, I removed it in setup.py. the return self._replace(**attributes, options=options) is forbidden, I replaced it. I waiting travis, but some test seem faild.

    I don't know if the fix will be easy.

    Do you want a PR for Python3.5 alone or you would like to wait both.

  2. Bogdanp commented on Nov 16, 2017

    @Bogdanp
    Owner

    Yeah, let's do it with 3.5 first. Don't forget to add yourself to the contributors file (people often do :P)!

  3. Bogdanp commented on Nov 17, 2017

    @Bogdanp
    Owner

    The 3.4 branch is blocked by this CPython issue: https://bugs.python.org/msg306427

  4. Bogdanp commented on Nov 17, 2017

    @Bogdanp
    Owner

    Since it sounds like the issue is not going to be fixed in 3.4, I'm not going to exert any more effort into supporting that version.

  5. jssuzanne commented on Nov 17, 2017

    @jssuzanne
    ContributorAuthor

    You are right, python 3.5 is a good step, enough for now

  6. Bogdanp commented on Nov 17, 2017

    @Bogdanp
    Owner

    Yup! I forgot to mention: 0.13.1 is released with support for 3.5 :D

  7. jssuzanne commented on Nov 17, 2017

    @jssuzanne
    ContributorAuthor

    I saw it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions