You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Actually dramatiq works only with python 3.6 and 3.7a. the linux distribution haven't got theses versions of python. Why don't you keep the capability to use use Python 3.4 and highter
For python 3.5, it is easy I have juste replaced print(f"{}") by print("%s" % ...) .
Python 3.4 is harder, yield from does not work with pip install, I removed it in setup.py. the return self._replace(**attributes, options=options) is forbidden, I replaced it. I waiting travis, but some test seem faild.
I don't know if the fix will be easy.
Do you want a PR for Python3.5 alone or you would like to wait both.
Activity
jssuzanne commentedon Nov 15, 2017
I have started, the implementation in the branch.
For python 3.5, it is easy I have juste replaced
print(f"{}")byprint("%s" % ...).Python 3.4 is harder, yield from does not work with pip install, I removed it in setup.py. the
return self._replace(**attributes, options=options)is forbidden, I replaced it. I waiting travis, but some test seem faild.I don't know if the fix will be easy.
Do you want a PR for Python3.5 alone or you would like to wait both.
Bogdanp commentedon Nov 16, 2017
Yeah, let's do it with 3.5 first. Don't forget to add yourself to the contributors file (people often do :P)!
Bogdanp commentedon Nov 17, 2017
The 3.4 branch is blocked by this CPython issue: https://bugs.python.org/msg306427
Bogdanp commentedon Nov 17, 2017
Since it sounds like the issue is not going to be fixed in 3.4, I'm not going to exert any more effort into supporting that version.
jssuzanne commentedon Nov 17, 2017
You are right, python 3.5 is a good step, enough for now
Bogdanp commentedon Nov 17, 2017
Yup! I forgot to mention: 0.13.1 is released with support for 3.5 :D
jssuzanne commentedon Nov 17, 2017
I saw it ;)