Skip to content

Make prometheus requirement optional #95

Description

@idahogray

I ran into Issue #75 today and I see the discussion there is about fixing the file locking mechanism on Windows. However, I don't use prometheus at all and I would prefer to make that dependency optional.

I am willing to spend some time on this but might need some mentoring to get it all integrated with the project.

Let me know if you would like me to pursue this.

Activity

  1. Bogdanp commented on Jun 17, 2018

    @Bogdanp
    Owner

    Unfortunately, that'd be a breaking change. It's one I'm planning to make, but it'll have to wait for a 2.0 release to come out. In the mean time, you can opt out of using prometheus by explicitly passing a list of middleware to your broker:

    broker = RabbitmqBroker(middleware=[
        AgeLimit(), TimeLimit(), ShutdownNotifications(),
        Callbacks(), Pipelines(), Retries()
    ])

    or

    from dramatiq.middleware import default_middleware
    
    # The first entry is always going to be the Prometheus middleware, at least until 2.0.
    broker = RabbitmqBroker(middleware=[m() for m in default_middleware[1:]])
  2. self-assigned this
    on Jun 17, 2018
  3. added this to the v2.0.0 milestone on Jun 17, 2018
  4. idahogray commented on Jun 17, 2018

    @idahogray
    Author

    Thanks for the quick response and I understand. I will probably for it and get started on the update. I will submit a pull request if I get anywhere.

  5. Bogdanp commented on Sep 29, 2018

    @Bogdanp
    Owner

    Closing for now per #96 (comment) .

  6. bersace commented on Feb 22, 2019

    @bersace
    Contributor

    Hi, #96 has been close and this issue too. Shouldn't we reopen it for 2.0 milestone ?

  7. Bogdanp commented on Feb 22, 2019

    @Bogdanp
    Owner

    @bersace both are superseded by #127 .

  8. bersace commented on Feb 22, 2019

    @bersace
    Contributor

    @Bogdanp thanks for pointing that. Would #127 patch drop hard requirement on prometheus-client ?

  9. Bogdanp commented on Feb 22, 2019

    @Bogdanp
    Owner

    Yup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions