New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Support redis py 3.0 #142

Closed
wants to merge 3 commits into
base: master
from

Conversation

2 participants
@maerteijn
Copy link
Contributor

maerteijn commented Nov 27, 2018

As I saw the "Help wanted" label for #136 here my first attempt (WIP) to fix the issues so Dramatiq works with the redis-py 3.0 package.

For as far I can see from the breaking changes the following issues have impact on dramatiq:

  • The StrictRedis class has been renamed to Redis. StrictRedis will continue to exist as an alias of Redis for the forseeable future.
  • The legacy Redis client class has been removed. It caused much confusion to users.
  • ZADD now requires all element names/scores be specified in a single dictionary argument named mapping. This was required to allow the NX, XX, CH and INCR options to be specified.

These issues are addressed in this pull request. disptach.lua seems to work fine, however I'm not so a LUA programmer so it could be luck that it still works 馃槃 Will investigate later or maybe you have some hints for me

@Bogdanp

This comment has been minimized.

Copy link
Owner

Bogdanp commented Nov 28, 2018

Thanks! I'll merge this for 1.5 sometime in the next couple of months.

@Bogdanp Bogdanp added this to the v1.5.0 milestone Nov 28, 2018

@Bogdanp Bogdanp modified the milestones: v1.5.0, v1.4.1 Dec 24, 2018

@Bogdanp

This comment has been minimized.

Copy link
Owner

Bogdanp commented Dec 24, 2018

Thanks again! I merged your changes with rebase (and some of my own tweaks on top) and will cut a release later today.

@Bogdanp Bogdanp closed this Dec 24, 2018

@Bogdanp Bogdanp referenced this pull request Dec 24, 2018

Closed

Upgrade to redis-py 3.0 #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment