Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
RabbitMQ priority #157
ryanhiebert left a comment •
I think this looks pretty cool, so good work! The implementation is simple enough that I can understand what you're doing, which I think speaks something really good about it. It would be more in line with RabbitMQ if the max priority were defined per queue, but that seems out of place for Dramatiq from what I can tell, as it doesn't seem like Dramatiq wants to have its queues pre-declared, so this change seems reasonable to me.
Interesting. My thinking is that since queues may be shared between actors, pulling the max_priority off the actor probably doesn't make sense. And even then, the queue need not be declared on the actor, so it's at best an unreliable way to set it. I think what you've written here makes the most sense.