Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop and join worker threads before consumers #160

Closed
wants to merge 1 commit into from

Conversation

@brownan
Copy link

@brownan brownan commented Jan 25, 2019

See #159 for discussion.

I don't have the full test suite running on my machine. Let me know if the CI isn't sufficient.

@Bogdanp
Copy link
Owner

@Bogdanp Bogdanp commented Jan 26, 2019

@brownan thanks. Please add yourself to the CONTRIBUTORS file and then I'll merge this.

This lets workers finish their work while the consumer threads continue
to update the heartbeat, preventing the tasks from being requeued by
other workers while it's still being executed.

Fixes #159
@brownan brownan force-pushed the brownan:master branch from 742842a to 0646c09 Jan 26, 2019
@brownan
Copy link
Author

@brownan brownan commented Jan 26, 2019

@Bogdanp Done, thanks!

@Bogdanp
Copy link
Owner

@Bogdanp Bogdanp commented Jan 31, 2019

Thanks again! I've merged your changes with rebase and will release them soon.

@Bogdanp Bogdanp closed this Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants