Stop and join worker threads before consumers#160
Closed
brownan wants to merge 1 commit intoBogdanp:masterfrom
Closed
Stop and join worker threads before consumers#160brownan wants to merge 1 commit intoBogdanp:masterfrom
brownan wants to merge 1 commit intoBogdanp:masterfrom
Conversation
Owner
|
@brownan thanks. Please add yourself to the |
This lets workers finish their work while the consumer threads continue to update the heartbeat, preventing the tasks from being requeued by other workers while it's still being executed. Fixes Bogdanp#159
Author
|
@Bogdanp Done, thanks! |
Owner
|
Thanks again! I've merged your changes with rebase and will release them soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #159 for discussion.
I don't have the full test suite running on my machine. Let me know if the CI isn't sufficient.