Allow to specify an actor class in actor decorator. - #169
Closed
gilbsgilbs wants to merge 1 commit into
Closed
Conversation
gilbsgilbs
force-pushed
the
actor-class
branch
2 times, most recently
from
February 12, 2019 22:28
31c4b93 to
2b3e8c1
Compare
Contributor
|
I would like to see the LazyActor you mentioned in #163 in this PR so it becomes "official" because I ran into a similar issue. |
Bogdanp
requested changes
Feb 14, 2019
| return "Actor(%(actor_name)s)" % vars(self) | ||
|
|
||
|
|
||
| def actor(fn=None, *, actor_name=None, queue_name="default", priority=0, broker=None, actor_class=Actor, **options): |
Owner
There was a problem hiding this comment.
Tiny nitpick: please move actor_class before actor_name. All of those are keyword-only arguments so it's not a breaking change and I like how it reads a little better.
Owner
|
@davidt99 I'd rather we mention this somewhere in the guide rather than include the code for @gilbsgilbs I just have that one tiny little nitpick. Otherwise, this looks good to me. |
gilbsgilbs
force-pushed
the
actor-class
branch
2 times, most recently
from
February 14, 2019 18:40
aec55ff to
9c792aa
Compare
Contributor
Author
|
Thanks for the review @Bogdanp . |
gilbsgilbs
force-pushed
the
actor-class
branch
from
February 14, 2019 18:44
9c792aa to
d132768
Compare
Owner
|
@gilbsgilbs thanks again. This is now merged with rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, I had to move the decorator function down so that I can get the
Actorclass declared soon enough, which kind of messes up the diff.Fixes #163