Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access broker in object attributes #191

Closed
wants to merge 2 commits into from
Closed

Conversation

@bersace
Copy link
Contributor

@bersace bersace commented Mar 18, 2019

Hi @Bogdanp,

I expected that Dramatiq would be able to resolve deep attribute access like you can define in pkg_resources entry-point. This PR add this behaviour, based on pkg_resources implementation ( https://github.com/pypa/setuptools/blob/ad98fcb350fa3ce63389520a391e23274de11064/pkg_resources/__init__.py#L2426-L2434 ).

This ease integration with e.g. Flask by accepting dramatiq some_module:app.broker construction.

What do you think of this ?

@Bogdanp
Copy link
Owner

@Bogdanp Bogdanp commented Mar 19, 2019

This is good, but it needs a test before I can merge it. Check out test_cli.py.

@bersace
Copy link
Contributor Author

@bersace bersace commented Mar 19, 2019

Hi @Bogdanp. Thanks for pointing at it. I choosed to update existing test to both check deep attribute accessing and instance check.

Appveyor doesn't have build logs for me. Do i need privileges or something else to have logs ?

@bersace
Copy link
Contributor Author

@bersace bersace commented Mar 19, 2019

@Bogdanp beware it's fixup. You either need to squash commits or let me rebase --autosquash before merging ! Thanks !

@Bogdanp Bogdanp added this to the v1.6.0 milestone Mar 20, 2019
@Bogdanp
Copy link
Owner

@Bogdanp Bogdanp commented Apr 1, 2019

Thanks. This has now been merged w/ rebase.

@Bogdanp Bogdanp closed this Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants