Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pipe_ignore has effect on sending message #194

Closed
wants to merge 3 commits into from
Closed

fix pipe_ignore has effect on sending message #194

wants to merge 3 commits into from

Conversation

@metheoryt
Copy link
Contributor

@metheoryt metheoryt commented Mar 20, 2019

fix issue when pipe_ignore has effect on sending message instead if receiving, as it described in documentation https://dramatiq.io/cookbook.html#pipelines

fix issue when pipe_ignore has effect on sending message instead if receiving, as it described in documentation
@Bogdanp
Copy link
Owner

@Bogdanp Bogdanp commented Mar 20, 2019

Thanks! Please add a test for this and don't forget to add yourself to CONTRIBUTORS.md.

@metheoryt
Copy link
Contributor Author

@metheoryt metheoryt commented Mar 26, 2019

I need some clarification about actor whose messages gets piped - should he be declared with store_result=True to be able to receive message result as argument or this feature is enabled as long as dramatiq has result backend?

UPD figured it out, store_result does not affect argument passing, only result fetching

@Bogdanp Bogdanp added this to the v1.6.0 milestone Apr 1, 2019
@Bogdanp
Copy link
Owner

@Bogdanp Bogdanp commented Apr 1, 2019

Thanks again! This is merged with rebase and will be released soon.

@Bogdanp Bogdanp closed this Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants