Skip to content

fix pipe_ignore has effect on sending message#194

Closed
metheoryt wants to merge 3 commits intoBogdanp:masterfrom
metheoryt:master
Closed

fix pipe_ignore has effect on sending message#194
metheoryt wants to merge 3 commits intoBogdanp:masterfrom
metheoryt:master

Conversation

@metheoryt
Copy link
Contributor

fix issue when pipe_ignore has effect on sending message instead if receiving, as it described in documentation https://dramatiq.io/cookbook.html#pipelines

fix issue when pipe_ignore has effect on sending message instead if receiving, as it described in documentation
@Bogdanp
Copy link
Owner

Bogdanp commented Mar 20, 2019

Thanks! Please add a test for this and don't forget to add yourself to CONTRIBUTORS.md.

@metheoryt
Copy link
Contributor Author

metheoryt commented Mar 26, 2019

I need some clarification about actor whose messages gets piped - should he be declared with store_result=True to be able to receive message result as argument or this feature is enabled as long as dramatiq has result backend?

UPD figured it out, store_result does not affect argument passing, only result fetching

@Bogdanp Bogdanp added this to the v1.6.0 milestone Apr 1, 2019
@Bogdanp
Copy link
Owner

Bogdanp commented Apr 1, 2019

Thanks again! This is merged with rebase and will be released soon.

@Bogdanp Bogdanp closed this Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants