Add a skip-logging flag to the CLI#263
Merged
Bogdanp merged 1 commit intoBogdanp:masterfrom Jan 14, 2020
Merged
Conversation
Contributor
Author
|
It looks like the CI failure was unrelated to this change. |
Owner
|
Thank you! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
skip-loggingflag to the CLI invocation arguments.This came from wanting to adjust the LOGFORMAT of Dramatiq's log messages. I wanted to eliminate the
[Thread-X]bit and modify the order of things to better match the rest of my systemlogging.basicConfigis a no-op if the root logger has handlers added to it, but due to the fact that the Dramatiq CLI is invoked before any of my code, there is no way to beat that to the punch.So instead I opted to add a
--skip-loggingflag that will preventbasicConfigfrom ever happening. This allows the end user to define the handlers and whatnot without having to undo anything done by Dramatiq's bootup sequence.Hopefully this is something that is worth merging into the project.