Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing delays of messages in a pipeline #264

Merged
merged 2 commits into from Jan 14, 2020

Conversation

synweap15
Copy link
Contributor

Fixes #206.

The delays of messages in the pipeline were ignored, only the delay parameter of pipeline's run method was taken into consideration.

This PR fixes the handling of delay parameters of messages in a pipeline (first and all following). In addition in alters the behavior of the delay parameter of pipeline's run method, so that:

  1. If there's either a delay specified for the first message or there's a delay specified in pipe run invocation, take the one that's present.
  2. If they are both present, take the one that has higher value.

@Bogdanp Bogdanp merged commit 099086b into Bogdanp:master Jan 14, 2020
@Bogdanp
Copy link
Owner

Bogdanp commented Jan 14, 2020

Thanks!

@synweap15 synweap15 deleted the pipeline-and-message-delay-fix branch January 14, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pipeline doesn't respect (at least) first message delay option
2 participants