Skip to content

Expose pipe's fileno to StreamablePipe#291

Closed
takhs91 wants to merge 1 commit intoBogdanp:masterfrom
advantis-io:streamablepipe-fileno
Closed

Expose pipe's fileno to StreamablePipe#291
takhs91 wants to merge 1 commit intoBogdanp:masterfrom
advantis-io:streamablepipe-fileno

Conversation

@takhs91
Copy link
Contributor

@takhs91 takhs91 commented Mar 27, 2020

If its not exposed any given tasks module that imports libraries that may internally call faulthandler.enable() will produce an exeption

AttributeError: 'StreamablePipe' object has no attribute 'fileno'

@Bogdanp
Copy link
Owner

Bogdanp commented Mar 28, 2020

Thanks! I've merged this with rebase.

@Bogdanp Bogdanp closed this Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants