Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose pipe's fileno to StreamablePipe #291

Closed
wants to merge 1 commit into from

Conversation

takhs91
Copy link
Contributor

@takhs91 takhs91 commented Mar 27, 2020

If its not exposed any given tasks module that imports libraries that may internally call faulthandler.enable() will produce an exeption

AttributeError: 'StreamablePipe' object has no attribute 'fileno'

@Bogdanp
Copy link
Owner

@Bogdanp Bogdanp commented Mar 28, 2020

Thanks! I've merged this with rebase.

@Bogdanp Bogdanp closed this Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants